Sphene Community Tools

Community

Copyright © 2007-2018 by Herbert Poul

You are not logged in.
Login
Register

Change Language:



AddThis Social Bookmark Button

A Django site.

Powered by Sphene Community Tools
Board » General » _displayCategories templates in forum correction

foa maybe create a bug submission forum for sphene.

The change I made in a local copy of the _displayCategories allows separators to work, even if they are not the standard separator:
{% if category.get_category_type.is_separator %}
...
{% endif %}
instead of
{% ifequal category.category_type "sphseparator" %}
...
{% endifequal %}
weltenfall.net
well for now the issue tracker from google code hosting is meant for bug reports & co .. but.. i guess this one is really better suited in the forums.. because i would like to discuss it :)

my first version actually used something similar .. but i decided to simply check the category id .. because i figured there wouldn't be a need for a custom separator category ?
would you mind explaining your specific need for this patch ?

thanks,
herbert
Hey, we have Signatures !!! Great, isn't it ? ;)
well explanation: its the right thing to do? you define an extra function for it, so it seems funny not to use it.

better question: why NOT doing it that way? whats the reason for doing it differently?
weltenfall.net
well .. i guess it would have been better to remove the function :)

iirc my motivation was that if a category is a separator or not is a difference in the template.. it doesn't matter too much to the model or view code ..
anyway .. it's not really important :) i'll think about it and probably change it ..
Hey, we have Signatures !!! Great, isn't it ? ;)

Please login to post a reply.



Powered by Sphene Community Tools